Approved [v1.12] C3Mod

Awesome! I'll see if the erpsystem integration still works. Thanks for updating! Is this publicly available I notice it mentions donors to twitchy

excellent work ill give it a spin!
olink- does your c3rewardsystem.dll reference twichys-c3mod.dll ?

ie. i see in the references of pluginmain.cs of c3rewardsystem it has:
using C3Mod;

ok great- well it seems to be working well so far. will be doing more testing today.

got this:

3/16/2012 7:10:52 PM
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
at System.Collections.Generic.List`1.Enumerator.MoveNextRare()
at System.Collections.Generic.List`1.Enumerator.MoveNext()
at C3Mod.C3Mod.OnUpdate()
at System.Action.Invoke()
at Hooks.GameHooks.OnUpdate(Boolean pre)
at Terraria.Main.DedServ()
at Terraria.ProgramServer.Main(String[] args)

dont want you to get caught debugging this though olink- i think this may have been around even before your update.

Very nice work still I need a hand — for now I care only about CtF mode.
Is there any way to make possible for players who disconnect or join the server to join game mode, like with command /join ctf or just joining corresponding team, because I can't make a good game if someone leaves or reconnects.
Thanks.

Exact same error ~5 minutes ago. This may be a problem bigger than the plugin itself, this particular error popped up from Jail and some other plugins.
3/16/2012 10:10:52 PM
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
at System.Collections.Generic.List`1.Enumerator.MoveNextRare()
at System.Collections.Generic.List`1.Enumerator.MoveNext()
at C3Mod.C3Mod.OnUpdate()
at System.Action.Invoke()
at Hooks.GameHooks.OnUpdate(Boolean pre)
at Terraria.Main.DedServ()
at Terraria.ProgramServer.Main(String[] args)

we werent running olinks updated one when the next error occurred. i just updated and will apply at next restart

Disregard this, I suck.

olink can u replace the OnPvPDeath with this:

Code:

        private static void OnPvPdeath(C3Mod.DeathArgs e)
        {
            if (e.PvPKill)
            {
                if( e.Killer.TSPlayer.IsLoggedIn && e.Killed.TSPlayer.IsLoggedIn)
                {
                    EPRPlayer EKiller = ServerPointSystem.ServerPointSystem.GetEPRPlayerByIndex(e.Killer.TSPlayer.Index);
                    EPRPlayer EKilled = ServerPointSystem.ServerPointSystem.GetEPRPlayerByIndex(e.Killed.TSPlayer.Index);
                    //The two ints here are the two account balances.
                    int killerbal = EKiller.DisplayAccount;
                    int killedbal = EKilled.DisplayAccount;
                    //If the two are within the proper range, it will add and deduct.
                    if(InPointRange(killerbal, killedbal))
                    {
                        //gain is one percent of the balance of the player killed multiplied by one hundred minus the deathtoll.
                        float gain = (killedbal * (100 - ServerPointSystem.ServerPointSystem.DeathToll)/100) + PvPKillReward;
                        //This notifies the player that they just pwned someone, and got some shards from them.
                        e.Killer.TSPlayer.SendMessage("You gained " + ((int)gain).ToString() + " " + ServerPointSystem.ServerPointSystem.currname + "(s)!", Color.Green);
                        //This adds points to the killer's shard count.
                        EPREvents.PointOperate(EKiller, (int)gain, PointOperateReason.PVP);
                        //The following is my proposed changes.
                        //Notify the loser of his losses.
                        e.Killed.TSPlayer.SendMessage("You lost " + ((int)gain).ToString() + " " + ServerPointSystem.ServerPointSystem.currname +"(s)!", Color.Green);
                        //Deduct the amount the killer gained by adding a negative amount. This appears to be how /deduct works, so I am mimicking it.
                        EPREvents.PointOperate(EKilled, -((int)gain),PointOperateReason.PVP);
                        //The comments were mainly for my own use, by the way.
                       
                    }
                }
            }
        }

It wasnt deducting shards from the loser causing an exploit. i would do it on my side but since u updated the c3rewards i dont know if mine works.

It looks like it.

id like to find out but 26 ppl decided to log on so now im at a bad spot to reboot.

ill know by tomorrow morning. thanks for the help olink (and dean)

just got this:
3/20/2012 8:58:24 PM
System.InvalidOperationException: Collection was modified; enumeration operation may not execute.
at System.ThrowHelper.ThrowInvalidOperationException(ExceptionResource resource)
at System.Collections.Generic.List`1.Enumerator.MoveNextRare()
at System.Collections.Generic.List`1.Enumerator.MoveNext()
at C3Mod.C3Mod.OnUpdate()
at System.Action.Invoke()
at Hooks.GameHooks.OnUpdate(Boolean pre)
at Terraria.Main.DedServ()
at Terraria.ProgramServer.Main(String[] args)

sorry man :\


EDIT: hmm looks like the same error as before.. i will redownload the plugin.

First of all... Thanks Olink for updating this great mod... But... Im running tschock 3.0.6.204 and all plugins are running fine... The only thing i miss in this one is choosing different arenas after selecting the game-mode... So my question is... Is it possible now (after updating the plugin to the newest tshock-version) to select different arenas for a duel (for example)? The problem seems to be the "arena-id" with the version i´m using...

best regard, Keinheld