2.1 TSWVote 2.3

It does not require a full dump of the users inventory. I can't just send the IP because I need to validate that the player is actually on the server. Otherwise, you wouldn't need to be on the server in order to place a vote. And then anyone could add fake votes!

Code:

/v2/users/read
Description: Returns information about a specified user
 
Parameters:
token - A valid token
type - (defaults to name) name, id or ip indicating what the "user" parameter refers to
user - The name, ip or id of a currently registered user
 
Returns:
group - The group the user belong's to
id - The user's ID
name - The name of the user
ip - The ip of the user 

 

Your info is outdated. Here's TShocks source:

Code:

return new RestObject()
            {
                {"nickname", player.Name},
                {"username", null == player.UserAccountName ? "" : player.UserAccountName},
                {"ip", player.IP},
                {"group", player.Group.Name},
                {"position", player.TileX + "," + player.TileY},
                {"inventory", string.Join(", ", activeItems.Select(p => (p.name + ":" + p.stack)))},
                {"buffs", string.Join(", ", player.TPlayer.buffType)}
            };

 

Someone needs to update the documentation then: https://tshock.atlassian.net/wiki/display/TSHOCKPLUGINS/REST+API+Endpoints

Here, it only says /v2/players/read returns that information!

 

So that nobody calls me a liar: https://github.com/NyxStudios/TShock/blob/general-devel/TShockAPI/Rest/RestManager.cs#L586-604 https://github.com/NyxStudios/TShock/blob/general-devel/TShockAPI/Rest/RestManager.cs#L91

Maybe you need /v2/users/read ?

 

That is /v2/users/read , not /v2/players/read

 

Well I don't know c#, that's not my lingo. I would ONLY get the IP if I could. But there isn't such an endpoint.

 

Dude this is sick, nice job. Keep up the good work buddy

 

You just made a typo in https://tshock.co/xf/index.php?threads/tserverweb-1-15-tswvote.2852/#post-32144 calling it /v2/players/read, but you did get the proper docs for /v2/users/read in https://tshock.co/xf/index.php?threads/tserverweb-1-15-tswvote.2852/page-2#post-32148.

Please, specify, which one of those you need

 

@Commaster;

 

That's totally not helping me trying to help you document the voting process properly. Y'now...

I have to take an 8 hours brake. Hope that you'll finish documenting the permissions by then ^_^

 

Honestly, it works fine for me? It's just that I've been working around with /bank give now and that doesn't seem to work (is what my players say) can't test it myself because I've voted already.

 

It worked for me!

 

The message didn't work though, I changed the message to: Thank you for voting on Tserverweb ([totalvotes])! You have received 500,000 (500K) Mesos for doing so. Be sure to vote on terraria-servers.com to receive 1,000,000 (1 Mil) Mesos!

But it just shows Thanks for voting!

 

Just fixed it.

 

Now the only problem is that we cannot test it out >_> damnit.

 

Here you go:

 

bananaing epic

 

Hey Loganizer!

Maybe you could make the command to votes or votetsw something like that? because c3mod use /vote instead and then getting the wrong gametype error...
Would be very nice!

EDIT: changed it self

 

First of all, you should indeed add threading.
Second of all, you should not be querying TShock REST API as it gives too much info. You should instead make your own endpoint that reports all the data you need in one query. And you should also not be able to execute commands on the server, instead you should let the server owner specify the command SERVERSIDE, not on your website, and only notify the server when to execute it and who voted.
Well, the second of all part is more of a security risk for you, since it would only require changing your source to report fake IPs, but then, if someone really wants to fake votes - they could just change TShock's source, or replace original TShock endpoints in some other way.

You got my point, right? I can fake TShock endpoints and report fake IPs (therefore fake votes). And there isn't really anything you can do. I don't think there is a secure way to implement this, man. Well, unless forcing in-game voters to register online first and somehow log in to their accounts on the server.